Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code display plugin on ClassicPress.net not working #1

Open
klein-the-donkey opened this issue Nov 6, 2019 · 4 comments
Open

Code display plugin on ClassicPress.net not working #1

klein-the-donkey opened this issue Nov 6, 2019 · 4 comments

Comments

@klein-the-donkey
Copy link

Is the plugin broken? I can't see the button in the editor and the code that's normally displayed like:
Schermafbeelding 2019-11-06 om 16 56 04
Is now displayed like:
Schermafbeelding 2019-11-06 om 16 55 42

@timbocode
Copy link
Contributor

As I recall, James had to remove the Crayon Syntax Highlighter plugin because it's not PHP7 compatible and was throwing numerous errors. @nylen should be able to confirm.

@nylen
Copy link
Contributor

nylen commented Nov 7, 2019

Yes, that's right. It's also pretty over-large for what it was doing. I'd be open to installing a lightweight replacement if you know of one.

@johnalarcon
Copy link
Contributor

johnalarcon commented Nov 8, 2019

I've worked on the plugin to bring it to PHP 7 compatibility. Also, if you remove the 50 needless languages, it's much slimmer; this involves just removing the directories. For the ClassicPress blog, leaving in only html, xml, apache, php, sql, css, javascript, and json would probably cover every last need. Removing the extras is 1/3 of the plugin.

@johnalarcon
Copy link
Contributor

johnalarcon commented Nov 10, 2019

I've built a slim and performant (250K footprint, 55K output) Syntax Highlighter plugin based on Prism. It still has one issue, but, may become a viable option for ClassicPress.net. Please give it a test-drive.

@nylen, I proposed a solution on this issue; is this the correct approach?

@nylen nylen transferred this issue from ClassicPress/ClassicPress-Network Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants