Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Crashes upon loading a save #65

Closed
StoneKill opened this issue Jul 16, 2024 · 5 comments
Closed

Editor Crashes upon loading a save #65

StoneKill opened this issue Jul 16, 2024 · 5 comments

Comments

@StoneKill
Copy link

During the process of me loading a save :

  • Game is in version app version 1.12.3
  • Game is in calibration version 1.12.4
  • DLC is installed
  • When I load the save, Steam is fully closed and not running in the backgroud
    The crash does not show any error messages, it just outright closes
@EthanShoeDev
Copy link

Duplicate #43

@nozwock
Copy link

nozwock commented Jul 16, 2024

The crash does not show any error messages, it just outright closes

It'll show it if you were to run it from the terminal, but only for the debug build, not really ideal. Currently, they've opted to crash the program rather than show an error message in the GUI since it's less work.

@nozwock
Copy link

nozwock commented Jul 16, 2024

Also a duplicate of #56

@renatopontes
Copy link

renatopontes commented Jul 28, 2024

I had this problem today and did some digging. While reading the save file, the code was reading some insanely large value for the projectile_count of a character and then went out of bounds in the next for loop:

// Distinct Projectile Count
equip_projectile_data.projectile_count = br.read_i32()?; // was reading something like 16980419

// Quick slot items
for _i in 0..equip_projectile_data.projectile_count { // obviously crashed
    equip_projectile_data.projectiles.push(EquipProjectile::read(br)?);
}

After some investigation, my theory is that the game only updates the character data in the save file when that character has been loaded after the update.
So, what fixed it for me was opening the game and then loading each character that I hadn't used since the DLC update. Upon loading, these characters receive the new gesture and get a tutorial pop up about the new inventory tab.
After that, the code was able to load the file correctly instead of panicking.

(tested on master version at 014107f, not on release 0.0.21)

@ClayAmore
Copy link
Owner

I'll close this as a duplicate of #43 . There's a bunch of forks with hot fixes for different versions of the game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants