Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some validation rules need changes #20

Open
michaelelfial opened this issue Oct 3, 2019 · 0 comments
Open

Some validation rules need changes #20

michaelelfial opened this issue Oct 3, 2019 · 0 comments
Labels
TO DO Task Well-defined Task

Comments

@michaelelfial
Copy link
Contributor

After auditing the rules, some have been fixed. However some more remain in need of fixing according to the requirements. The issues are:

  • The requirement to check only what you understand and return correct otherwise is overlooked or not applied correctly. The checks if the value is in the rule's domain of responsibility are lax or even incorrect sometimes. E.g. Numeric rules should perform validation only on numbers - if the value is not a number, nothing should be done.
  • Date rules need review and update to use the current standard formatters. They should support smarter than now approach to parsing their parameters, letting the developer to specify the dates (max/min for example) in some universal format. More properties can be added to effect configuration of the formats expected and the other aspects of the rules behavior.
@michaelelfial michaelelfial added the TO DO Task Well-defined Task label Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TO DO Task Well-defined Task
Projects
None yet
Development

No branches or pull requests

1 participant