Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh and update SimpleViewWindow, merge the IViewHostWindowImpl into SimpleViewWindow and retire the implementor. #3

Open
2 tasks
michaelelfial opened this issue Apr 12, 2019 · 0 comments
Open
2 tasks

Refresh and update SimpleViewWindow, merge the IViewHostWindowImpl into SimpleViewWindow and retire the implementor. #3

michaelelfial opened this issue Apr 12, 2019 · 0 comments
Labels
TO DO Task Well-defined Task

Comments

@michaelelfial
Copy link
Contributor

  • Merge IViewHostWindowImpl into SimpleViewWindow
  • Review SimpleViewWindow, clean up the logic a little and modernize it as necessary.

The implementer IViewHostWindowImpl was created as a precaution - we were not sure how many window classes will need to be able to host views. Now that it is clear we do not need more than one - they should merge and reduce the complexity of the code a little this way.

I believe these tasks should be done in the order they are listed. I noticed some very old and unused stuff in SimpleViewWindow - some clean up should be done for sure, also review of its behavior in respect to the hosted view may be a good idea.
@michaelelfial michaelelfial added the TO DO Task Well-defined Task label Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TO DO Task Well-defined Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelelfial