Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MCP mappings for in-repo patches #27

Open
Ecdcaeb opened this issue Jan 6, 2024 · 3 comments
Open

Use MCP mappings for in-repo patches #27

Ecdcaeb opened this issue Jan 6, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Ecdcaeb
Copy link
Contributor

Ecdcaeb commented Jan 6, 2024

LexManos use official mappings for in-repo patches, will be converted to SRG during build.
Should we do the same things?
MinecraftForge/MinecraftForge@40a7998
@Rongmario
Copy link
Member

Since we're on a non-competing version of mappings, we might even switch to mcp names even at runtime in the future.

I welcome this kind of change, we should use mcp wherever possible.

@kappa-maintainer kappa-maintainer added the enhancement New feature or request label Jan 6, 2024
@Rongmario Rongmario mentioned this issue Feb 17, 2024
Open
@Ecdcaeb
Copy link
Contributor Author

Ecdcaeb commented May 11, 2024

Ah, LexManos uses runtime-offical in new Forge.

@Rongmario
Copy link
Member

In the newest 1.20.4+ I believe, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Rongmario @kappa-maintainer @Ecdcaeb