Error handling: avoid uncaught errors

[antoinep92]

I was hit by a crypto exception from sign_request which is not handled by the lib and cannot be caught at top-level because it's asynchronous. I think it's related to #236, but looking at the code, error handling is lacking in multiple locations, which is why I think it makes sense to look at it with a broader perspective.

I realize this is free software, and I'm willing to make a PR for this. But before working on this I'd like to check if there was a chance it would be merged ? The idea would be to extend the scope of existing try/catch and add missing ones, at each "async level", so that errors don't crash the node process and are easier to backtrace.

[darioackermann]

Hey! Not sure if this is still a thing for you, but I'm willing to review and merge any PR regarding this into my fork. :-)

[antoinep92]

It is still a thing, but pretty low priority right now unfortunately. But thanks for your work trying to revive this, I'll try to push something when I can.