Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incrementing outputs break graceful_exit #3368

Open
charleskawczynski opened this issue Oct 8, 2024 · 1 comment
Open

Incrementing outputs break graceful_exit #3368

charleskawczynski opened this issue Oct 8, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@charleskawczynski
Copy link
Member

In order to gracefully exit, the output directory must stay the same. Perhaps we can change the graceful exit directory to dirname(output_dir) or something? Basically, we need a single and unchanging place for this output, since we're reading from, not writing to, this file.

@charleskawczynski charleskawczynski added the bug Something isn't working label Oct 8, 2024
@Sbozzolo
Copy link
Member

Sbozzolo commented Oct 8, 2024

In order to gracefully exit, the output directory must stay the same. Perhaps we can change the graceful exit directory to dirname(output_dir) or something? Basically, we need a single and unchanging place for this output, since we're reading from, not writing to, this file.

You can always assume that most recent output is in output_active (that was the intent of the link: to provide a stable and deterministic path), but I agree that the most robust solution is to use output_dir directly, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants