Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove more CoupledSimulation fields #1060

Open
juliasloan25 opened this issue Nov 5, 2024 · 0 comments
Open

remove more CoupledSimulation fields #1060

juliasloan25 opened this issue Nov 5, 2024 · 0 comments

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Nov 5, 2024

We have two CoupledSimulation fields that are only used in our checkpointing callback. We're in the process of changing our checkpointing, so as this changes hopefully we can remove these.

This is a followup to #1015

Fields to remove

  • comms_ctx
    • this is also used in this barrier, but I think we can remove it
  • dirs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant