Add high resolution clm data artifact #1007
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also modifies the `lm_data_folder_path` function to accept a new keyword argument: `lowres`, which determines if the normal (old) artifact or highres artifact path is returned. This is also added to the `clm_canopy_parameters` function.
imreddyTeja
force-pushed
the
tr/add-high-res-clm-data
branch
from
09b5088 to
477838c
Compare
Sbozzolo
reviewed
Feb 4, 2025
imreddyTeja
force-pushed
the
tr/add-high-res-clm-data
branch
from
51ae294 to
058042a
Compare
12 tasks
|
Looks good. Can we just be more precise in terms of the resolution. High vs low res is relative. Can we call it 0.125 instead? |
The name is now changed to "clm_data_0.125" |
braghiere
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Along with the accompanying ClimaArtifacts PR, this
closes #999
Content
Adds the new artifact to Artifacts.toml.
This commit also modifies theclm_data_folder_pathfunction to accept a new keyword argument:lowres, which determines if the normal (old) artifact or highres artifact path is returned. This is also added to theclm_canopy_parametersfunction.This PR replaces the
clm_dataartifact with theclm_data_highresartifact