Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Rearrange AtmosModel type hierarchy #2061

Open
charleskawczynski opened this issue Feb 25, 2021 · 0 comments
Open

Rearrange AtmosModel type hierarchy #2061

charleskawczynski opened this issue Feb 25, 2021 · 0 comments
Labels
Abstractions 🎨 Concerning the metaphysical aspects of climate modeling Atmos Atmosphere

Comments

@charleskawczynski
Copy link
Member

Description

One issue I'm seeing when trying to refactor the atmos BCs is that we construct the BCs before an AtmosModel is constructed. This results in awkward initialization because all of the physics components need to be synchronized on initialization. If we decompose our AtmosModel into

AtmosModel

  • AtmosPDEs
  • AtmosBCs
    Then we could compose the AtmosBCs easily from AtmosPDEs (which is currently the atmos model).

Thoughts? cc @kpamnany @simonbyrne
@charleskawczynski charleskawczynski added Atmos Atmosphere Abstractions 🎨 Concerning the metaphysical aspects of climate modeling labels Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Abstractions 🎨 Concerning the metaphysical aspects of climate modeling Atmos Atmosphere
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@charleskawczynski