Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve names #11

Closed
charleskawczynski opened this issue Mar 31, 2024 · 2 comments · Fixed by #23
Closed

Improve names #11

charleskawczynski opened this issue Mar 31, 2024 · 2 comments · Fixed by #23

Comments

@charleskawczynski
Copy link
Member

I think the primary feature of this package will be to collect broadcast expressions into a tuple. There may different ways to construct this tuple, and each approach may have its own limitations and pros/cons (#5). That said, the primary feature of this package is really about constructing these tuples, and we should think about good names for this feature. Currently fused_pairs is not really descriptive in terms of the approach/limitations etc.

Some ideas that come to mind are:

  • fused_pairs_basic - the current fused implementation, which is "safe" in that it's less easy to misuse
  • fused_pairs_all/fused_pairs_unsafe? - allowed across loops, but cannot contain arbitrary function calls, aliasing (?)
@charleskawczynski
Copy link
Member Author

Maybe local_pairs and nonlocal_pairs?

@charleskawczynski
Copy link
Member Author

Or, maybe:

  • @make_fused/@make_fused_once FusedBroadcast fused
  • @make_fused_runtime FusedBroadcast runtime_fused
    ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant