Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .= syntax #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support .= syntax #26

wants to merge 1 commit into from

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented May 1, 2024

Closes #17.

I'm a little weary of these changes, as I think it could open the door to subtle bugs.

@charleskawczynski charleskawczynski requested a review from vchuravy May 1, 2024 20:06
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 69.15%. Comparing base (0d6c83c) to head (41fa27b).

Files Patch % Lines
src/collection/utils.jl 50.00% 3 Missing ⚠️
src/collection/fused_assemble.jl 87.50% 1 Missing ⚠️
src/collection/fused_direct.jl 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   68.85%   69.15%   +0.30%     
==========================================
  Files           8        8              
  Lines         183      201      +18     
==========================================
+ Hits          126      139      +13     
- Misses         57       62       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests / support for y .= x syntax
1 participant