Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply a few fixes #47

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Apply a few fixes #47

merged 1 commit into from
Oct 10, 2024

Conversation

charleskawczynski
Copy link
Member

In this PR, we:

  • Use the occupancy API to determine the thread-block
  • Add @inbounds in the kernel
  • Use Int32 for the thread index computation
  • Apply lower-bound in addition to upper bound when validating the thread index (1 ≤ idx ≤ nitems)
  • Instantiate the broadcast object, so that axes are defined inside the kernel
  • Use Vararg to force specialization on rcopyto_at!
  • Make fused_copyto! return destinations, to follow the API of Base.copyto!.

@charleskawczynski charleskawczynski merged commit 041fdee into main Oct 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant