Adds momentum equation test for Enzyme extension #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
reviewed
Oct 4, 2024
Comment on lines
+309
to
+311
| #buoyancy = buoyancy, | ||
| #tracers = (:T, :S), | ||
| #velocities = PrescribedVelocityFields(; u, v), |
There was a problem hiding this comment.
Suggested change
| #buoyancy = buoyancy, | |
| #tracers = (:T, :S), | |
| #velocities = PrescribedVelocityFields(; u, v), |
glwagner
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
I suggest you set up a system that allows you to loop through model properties to generate a bunch of tests automatically. For example, we can run the current test with a few advection schemes. If you set the models up with a passive tracer c, you can use derivatives of that for all configurations including for prescribed velocities and prognostic velocities.
navidcy
changed the title
glwagner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test for Enzyme AD applied to a hydrostatic free surface model with
ExplicitFreeSurfacemomentum advection.