Variance dissipation computation #3877
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about TracerVarianceDissipation, omitting Computation? |
|
@simone-silvestri this is great! Looking forward to trying this out! One quick question: since this is a diagnostic quantity, would it make sense to include this on Oceanostics instead of Oceananigans? |
glwagner
reviewed
Nov 5, 2024
Comment on lines
54
to
55
| # Note: This works only if the callback is called with an IterationInterval(1), if not the | ||
| # previous fluxes and velocities will not be correct |
There was a problem hiding this comment.
You can actually enforce this by extending the Callback constructor
glwagner
reviewed
Nov 7, 2024
Comment on lines
+192
to
+194
| include("VarianceDissipationComputation/VarianceDissipationComputation.jl") | ||
|
|
||
| using .VarianceDissipationComputation |
There was a problem hiding this comment.
Suggested change
| include("VarianceDissipationComputation/VarianceDissipationComputation.jl") | |
| using .VarianceDissipationComputation | |
| include("VarianceDissipations/VarianceDissipations.jl") | |
| using .VarianceDissipations |
There was a problem hiding this comment.
This is explicitly the julia convention for modules whose primary purpose is to introduce a type
glwagner
reviewed
Nov 7, 2024
|
|
||
| prod_names = Tuple(Symbol(:A, tracer_name, dir) for dir in dirs) | ||
| diff_names = Tuple(Symbol(:D, tracer_name, dir) for dir in dirs) | ||
| grad_names = Tuple(Symbol(:G, tracer_name, dir) for dir in dirs) |
glwagner
reviewed
Nov 7, 2024
| diffusive_prod = Tuple(getproperty(D, dir) for dir in dirs) | ||
| grad = Tuple(getproperty(G, dir) for dir in dirs) | ||
|
|
||
| return NamedTuple{tuple(prod_names..., diff_names..., grad_names...)}(tuple(advective_prod..., diffusive_prod..., grad...)) |
There was a problem hiding this comment.
ummm
you may have meant to write something like
names = tuple(prod_names..., diff_names..., grad_names...)
glwagner
reviewed
Nov 7, 2024
| z = ZFaceField(grid) | ||
|
|
||
| return (; x, y, z) | ||
| end |
glwagner
reviewed
Nov 7, 2024
|
|
||
| Vⁿ.x[i, j, k] = _diffusive_tracer_flux_x(i, j, k, grid, clo, K, Val(c_id), c, clk, fields, b) * Axᶠᶜᶜ(i, j, k, grid) | ||
| Vⁿ.y[i, j, k] = _diffusive_tracer_flux_y(i, j, k, grid, clo, K, Val(c_id), c, clk, fields, b) * Ayᶜᶠᶜ(i, j, k, grid) | ||
| Vⁿ.z[i, j, k] = _diffusive_tracer_flux_z(i, j, k, grid, clo, K, Val(c_id), c, clk, fields, b) * Azᶜᶜᶠ(i, j, k, grid) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a metric to compute the implicit dissipation introduced by flux form advection schemes.
This metric has been devised by @jm-c and is still subject of some tests + writeup of the method, so this PR is still very much a work in progress.