Use triads (Griffies et al 1998) to compute the skew flux #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navidcy
approved these changes
Nov 17, 2024
|
@navidcy There few things to sort out before merging this PR. Checking today with @glwagner and @simone-silvestri |
|
I think we should just run the global 1 degree simulation and see if it works, then merge? There is also a performance issue that needs to be sorted, see #3938 |
|
@jm-c did you test it? how's it performing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the triad discretization for the Gent-McWilliams skew flux following Griffies et al 1998.
@jm-c
Running
/validation/isopycnal_skew_symmetric_diffusivity/coarse_baroclinic_adjustment.jlproducescoarse_baroclinic_adjustment_y.mp4
I think its working?