-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of spacings and correction of spacings-connected bugs #3955
base: main
Are you sure you want to change the base?
Conversation
I was thinking of using this PR to tackle also issue #3957. What do people think about it? |
ImmersedBoundaryGrid
ImmersedBoundaryGrid
+ Unification of general grid metrics
ImmersedBoundaryGrid
+ Unification of general grid metrics
The PartialCellBottom example crashes with this bugfix. I suggest I just revert this PR not to close #3958 and we can tackle that in a new PR if that's ok. |
In this PR there is a suggestion to improve the internals following #3957. |
Sounds good to me!
I'm also okay with this. Is this a breaking change? |
I think it's not breaking. The metrics that were defined in using Oceananigans.AbstractOperations: Ax
c = CenterField(grid)
cAx = c * Ax can be done in this PR with using Oceananigans.Operators: Ax
c = CenterField(grid)
cAx = c * Ax However, since |
Correct spacings on an
ImmersedBoundaryGrid
closes #3954
closes #3701
Should correct also partial cell bottomUnification of general grid metrics
closes #3957