Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are two distinct universal_func_types #145

Open
glwagner opened this issue Jan 10, 2024 · 0 comments · May be fixed by #149
Open

There are two distinct universal_func_types #145

glwagner opened this issue Jan 10, 2024 · 0 comments · May be fixed by #149
Labels
Quality assurance question Further information is requested

Comments

@glwagner
Copy link
Member

There are two functions called universal_func_type. One is defined in UniversalFunctions:

universal_func_type(::Type{T}) where {T <: BusingerParams} = BusingerType()

and the other is defined in Parameters:

universal_func_type(::SurfaceFluxesParameters{FT, AUFPS}) where {FT, AUFPS} = UF.universal_func_type(AUFPS)

The prefix UF in the second is what allows this duplication.

The Parameters version is called here:

uft = SFP.universal_func_type(param_set)

This is annoying if one needs to extend universal_func_type in an external package, so I propose we eliminate the dichotomy and use just one function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality assurance question Further information is requested
Projects
None yet
1 participant