Consider caching saturation vapor pressure #119
Labels
Comments
bors bot
added a commit
that referenced
this issue
Aug 8, 2022
123: Use p_vap_sat func in q_vap_sat r=charleskawczynski a=charleskawczynski This PR is a small refactoring step towards #119. This PR: - Slightly generalizes `saturation_vapor_pressure` to allow users to provide a phase partition - `saturation_vapor_pressure` is then called inside `q_vap_saturation`, whose contents were moved over This mostly just deletes duplicate code. There is a bit of algebraic difference between the two, but I've confirmed that they're equivalent. Co-authored-by: Charles Kawczynski <[email protected]>
bors bot
added a commit
that referenced
this issue
Aug 9, 2022
124: Reduce number of ^ calls r=charleskawczynski a=charleskawczynski This PR - Adds a few methods that allow us to compute saturation vapor pressure ahead of time - Reduce the number of saturation vapor pressure calls using these new methods - a step towards #119 Co-authored-by: Charles Kawczynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Computing saturation vapor pressure includes both calls to
expand^here, and based on looking at flame graphs in ClimaAtmos, it seems that this is actually pretty expensive.The text was updated successfully, but these errors were encountered: