Convert data-based test to sampling-based test #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/dataset_tests
branch
from
8bde885
to
abe89b0
Compare
charleskawczynski
force-pushed
the
ck/dataset_tests
branch
from
abe89b0
to
a10916e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
=======================================
Coverage 93.06% 93.06%
=======================================
Files 10 10
Lines 1139 1139
=======================================
Hits 1060 1060
Misses 79 79 ☔ View full report in Codecov by Sentry. |
auto-merge was automatically disabled
January 19, 2024 19:12
Merge queue setting changed
charleskawczynski
removed this pull request from the merge queue due to the queue being cleared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of the collected dataset, and replaces it with a sampling-based test based on the range of the dataset. I can confirm that the new tests works for
maxiter = 4and fails formaxiter = 3, which seems sufficient in terms of replacing the use of the dataset. This is nice because now we can remove ArtifactWrappers and NCDatasets from the test environment.