Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kernel benchmark #184

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Update kernel benchmark #184

merged 1 commit into from
Jan 20, 2024

Conversation

charleskawczynski
Copy link
Member

I think the original kernel benchmark I added was very memory bound (from the output array), as a result performance changes would be hidden by the bandwidth of loading the output array.

What I think we're really interested in here is flops inside a realistic kernel, and memory reads necessary for a single thermo state.

I've updated the kernel benchmark to address the first part (flops), and we should write a test for the memory reads necessary for a single thermo state, however, it will require a bit more work, and it'll be somewhat brittle to compare a broadcast call vs a custom kernel. Interesting, the kernel in this PR seems to be about 3x faster than the broadcast function call, I'll need to dig into that later.

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2735f2) 92.91% compared to head (ca56ec8) 92.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files          10       10           
  Lines        1143     1143           
=======================================
  Hits         1062     1062           
  Misses         81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charleskawczynski charleskawczynski added the Launch Buildkite Add label to launch Buildkite label Jan 20, 2024
@charleskawczynski charleskawczynski added this pull request to the merge queue Jan 20, 2024
Merged via the queue into main with commit dd73501 Jan 20, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant