From 89dfc16e75e34cf3016d21fd00ee4e3ca9e9466f Mon Sep 17 00:00:00 2001 From: Vineeth Asok Kumar <me@vineethasok.com> Date: Fri, 27 Oct 2023 10:50:54 +0200 Subject: [PATCH] Fix sidebar cursor (#188) * Update tokens * Add cursor pointer --- src/components/SidebarNavigationItem/SidebarNavigationItem.tsx | 1 + .../SidebarNavigationTitle/SidebarNavigationTitle.tsx | 1 + src/styles/types.ts | 3 ++- src/styles/variables.classic.json | 3 ++- src/styles/variables.dark.json | 3 ++- src/styles/variables.json | 3 ++- src/styles/variables.light.json | 3 ++- 7 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/components/SidebarNavigationItem/SidebarNavigationItem.tsx b/src/components/SidebarNavigationItem/SidebarNavigationItem.tsx index a01e17cc..03e8c9a3 100644 --- a/src/components/SidebarNavigationItem/SidebarNavigationItem.tsx +++ b/src/components/SidebarNavigationItem/SidebarNavigationItem.tsx @@ -48,6 +48,7 @@ export const SidebarItemWrapper = styled.div<{ white-space: nowrap; overflow: hidden; flex-wrap: nowrap; + cursor: pointer; ${({ theme, $collapsible = false, $level, $type }) => { const itemType = $level === 0 ? "item" : "subItem"; return ` diff --git a/src/components/SidebarNavigationTitle/SidebarNavigationTitle.tsx b/src/components/SidebarNavigationTitle/SidebarNavigationTitle.tsx index de78b1dd..788e5d89 100644 --- a/src/components/SidebarNavigationTitle/SidebarNavigationTitle.tsx +++ b/src/components/SidebarNavigationTitle/SidebarNavigationTitle.tsx @@ -48,6 +48,7 @@ export const SidebarTitleWrapper = styled.button<{ width: stretch; white-space: nowrap; overflow: hidden; + cursor: pointer; ${({ theme, $collapsible = false, $type }) => ` padding: 0; padding-left: ${$collapsible ? 0 : theme.click.image.sm.size.width}; diff --git a/src/styles/types.ts b/src/styles/types.ts index 101acb3f..d3d8f961 100644 --- a/src/styles/types.ts +++ b/src/styles/types.ts @@ -2222,7 +2222,8 @@ "color": { "background": { "default": string, - "muted": string + "muted": string, + "sidebar": string }, "text": { "default": string, diff --git a/src/styles/variables.classic.json b/src/styles/variables.classic.json index c1071834..7b12d36f 100644 --- a/src/styles/variables.classic.json +++ b/src/styles/variables.classic.json @@ -566,7 +566,8 @@ "color": { "background": { "default": "#ffffff", - "muted": "#f6f7fa" + "muted": "#f6f7fa", + "sidebar": "#2f2c3a" }, "text": { "default": "#161517", diff --git a/src/styles/variables.dark.json b/src/styles/variables.dark.json index bba25370..296287fa 100644 --- a/src/styles/variables.dark.json +++ b/src/styles/variables.dark.json @@ -1162,7 +1162,8 @@ "color": { "background": { "default": "#1F1F1C", - "muted": "#282828" + "muted": "#282828", + "sidebar": "#1F1F1C" }, "text": { "default": "#ffffff", diff --git a/src/styles/variables.json b/src/styles/variables.json index 4fedf1bc..14757c1e 100644 --- a/src/styles/variables.json +++ b/src/styles/variables.json @@ -2221,7 +2221,8 @@ "color": { "background": { "default": "#ffffff", - "muted": "#f6f7fa" + "muted": "#f6f7fa", + "sidebar": "#ffffff" }, "text": { "default": "#161517", diff --git a/src/styles/variables.light.json b/src/styles/variables.light.json index c683792e..c196378e 100644 --- a/src/styles/variables.light.json +++ b/src/styles/variables.light.json @@ -1155,7 +1155,8 @@ "color": { "background": { "default": "#ffffff", - "muted": "#f6f7fa" + "muted": "#f6f7fa", + "sidebar": "#ffffff" }, "text": { "default": "#161517",