Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input_format_null_as_default flag not available as a valid connection query param #1750

Closed
thiagohora opened this issue Jul 27, 2024 · 4 comments · Fixed by #1841
Closed
Assignees
Milestone

Comments

@thiagohora
Copy link

Describe your feedback

I have a use case where I would like to set this property input_format_null_as_default to false; however, as it is not a valid query param option, I would need to execute it in every request.

@chernser
Copy link
Contributor

@thiagohora, thank you for your feedback!

Would next code work for you:

       Client client = new Client.Builder()
                .addEndpoint(node.toUri().toString())
                .setUsername("default")
                .setPassword("")
                .setOption("input_format_null_as_default ", "false")
                .build();

Here is another example: https://github.com/ClickHouse/clickhouse-java/blob/main/client-v2/src/test/java/com/clickhouse/client/ClientTests.java#L69

@thiagohora
Copy link
Author

I think so. However, typically, frameworks abstract the instantiation of the client/connection factory. Just a suggestion, but I believe this should be supported via connection string as a queryparam

@mshustov
Copy link
Member

mshustov commented Aug 7, 2024

Just a suggestion, but I believe this should be supported via connection string as a queryparam

@chernser, that's a valid point. Other language clients support this method.
python client
nodejs client

@chernser Once it's implemented, could you also update the language client spec with this requirement?

@chernser
Copy link
Contributor

@mshustov will do and will update the language spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants