You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issues exist in feed.py and score_nodes.py and should be refactored. Score nodes presently uses unconventional python naming with variables in ALL_CAPS format, has a few variables that are declared and never used, and does not use dependency injection as it should. It is only used by the feed, but is located in the scoring folder so it should be relocated. Imports should be in Pep8 order & relative imports should be used when possible. Storing the climate feed into the db should not occur in this class.
Feed uses some variables in ALL_CAPS, a generalized try/except to catch multiple types of errors, and imports are not in pep8 order.Both should use Pep 287 reST formatting for docstrings
The text was updated successfully, but these errors were encountered:
Issues exist in feed.py and score_nodes.py and should be refactored. Score nodes presently uses unconventional python naming with variables in ALL_CAPS format, has a few variables that are declared and never used, and does not use dependency injection as it should. It is only used by the feed, but is located in the scoring folder so it should be relocated. Imports should be in Pep8 order & relative imports should be used when possible. Storing the climate feed into the db should not occur in this class.
Feed uses some variables in ALL_CAPS, a generalized try/except to catch multiple types of errors, and imports are not in pep8 order.Both should use Pep 287 reST formatting for docstrings
The text was updated successfully, but these errors were encountered: