Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Feed Routes & Score Nodes #265

Closed
seanmajorpayne opened this issue Oct 10, 2021 · 0 comments
Closed

Refactor Feed Routes & Score Nodes #265

seanmajorpayne opened this issue Oct 10, 2021 · 0 comments
Assignees
Labels
bug Something isn't working refactoring

Comments

@seanmajorpayne
Copy link
Member

Issues exist in feed.py and score_nodes.py and should be refactored. Score nodes presently uses unconventional python naming with variables in ALL_CAPS format, has a few variables that are declared and never used, and does not use dependency injection as it should. It is only used by the feed, but is located in the scoring folder so it should be relocated. Imports should be in Pep8 order & relative imports should be used when possible. Storing the climate feed into the db should not occur in this class.

Feed uses some variables in ALL_CAPS, a generalized try/except to catch multiple types of errors, and imports are not in pep8 order.Both should use Pep 287 reST formatting for docstrings

@seanmajorpayne seanmajorpayne added bug Something isn't working refactoring labels Oct 10, 2021
@seanmajorpayne seanmajorpayne self-assigned this Oct 10, 2021
@seanmajorpayne seanmajorpayne linked a pull request Oct 10, 2021 that will close this issue
@seanmajorpayne seanmajorpayne removed a link to a pull request Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactoring
Projects
None yet
Development

No branches or pull requests

1 participant