Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Prometheus metrics #19

Open
michaeljs1990 opened this issue Nov 25, 2019 · 1 comment
Open

Add support for Prometheus metrics #19

michaeljs1990 opened this issue Nov 25, 2019 · 1 comment

Comments

@michaeljs1990
Copy link

michaeljs1990 commented Nov 25, 2019

This is a duplicate of Symantec/Dominator#432 that I am moving over to this repo.

Of relevance in that ticket is the following from @rgooch.

I'm not really keen on that. I consider the tricorder/Scotty ecosystem a better solution (it supports more than floats and has a better UI for humans to discover and explore the available metrics for an application), and it follows the vision of more integrations in the metrics space (like integrating with the health-agent for health checking during rollouts). Also, I don't want to add another code dependency and bloat out the system. Note also that the tricorder library creates a /metrics endpoint already.

What might be a good alternative is to add the ability to push metrics from Scotty to Prometheus. The advantage of this approach is that none of the Dominator ecosystem components need to be changed.

Please take a look:
https://github.com/Symantec/scotty
https://docs.google.com/document/d/e/2PACX-1vQPhkHYiLK7aKHLECa9EFtSCBSPK-obgGB8C66d72Kl-ej9NikRKYGsuFj1R9aDTlGiZA7OmXrVw8P3/pub

Is this still the correct path to take for getting prom style metrics out of dominator in a way that can be contributed back upstream? I think some additional conversation may need to happen in the scotty repo mostly around prom scraping scotty instead of scotty pushing to it if that is an option.

@rgooch
Copy link
Member

rgooch commented Nov 28, 2019

So, an alternative that I've discussed with @cviecco is to modify the tricorder library to also publish Prometheus-compatible metrics. If that can be done cheaply without adding external dependencies, that might be a better approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants