Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermitent Superflous Error message when using okta code #74

Open
cviecco opened this issue Sep 30, 2020 · 2 comments
Open

Intermitent Superflous Error message when using okta code #74

cviecco opened this issue Sep 30, 2020 · 2 comments
Assignees

Comments

@cviecco
Copy link
Contributor

cviecco commented Sep 30, 2020

There is a race condition between the background loop checking for okta push and the user sending a code. If the code is sent the background task might also send a query which will be invaldated because the user has already logged in.

We need to suspend sending background requests as soon as the user submits a code.

@cviecco cviecco self-assigned this Sep 30, 2020
@cviecco
Copy link
Contributor Author

cviecco commented Sep 30, 2020

@rgooch : This can be fixed by serializing access to the okta/vip backend. Any concerns before I go that path?

@rgooch
Copy link
Member

rgooch commented Oct 1, 2020

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants