Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a configurable map for any hardcoded metric used in implementation #260

Open
moebiusband73 opened this issue Apr 24, 2024 · 1 comment · May be fixed by #289
Open

Provide a configurable map for any hardcoded metric used in implementation #260

moebiusband73 opened this issue Apr 24, 2024 · 1 comment · May be fixed by #289
Labels
backend backend API related issues enhancement New feature or request frontend Svelte UI related issues
Milestone

Comments

@moebiusband73
Copy link
Member

Currently at several places metric names are hardcoded. This breaks if the metric is missing or the user configured it with a different name.

Solution:
Provide a lookup map that can be configured by the user and replace any hardcoded metric name with a check in the lookup map.

@moebiusband73 moebiusband73 added enhancement New feature or request frontend Svelte UI related issues backend backend API related issues labels Apr 24, 2024
@moebiusband73 moebiusband73 mentioned this issue Apr 24, 2024
@moebiusband73 moebiusband73 added this to the Release 1.4.0 milestone Apr 24, 2024
@spacehamster87
Copy link
Contributor

spacehamster87 commented Apr 26, 2024

In this specific case (JobFootprint) we need four configurable arrays to allow for the following cases:

  • Metrics shown in Footprint for Exclusive CPU Jobs
  • Metrics shown in Footprint for Shared CPU Jobs
  • Metrics shown in Footprint for Exclusive GPU Jobs
  • Metrics shown in Footprint for Shared GPU Jobs

That being said, four metrics (cpu_load, flopy_any, mem_bw, mem_used) still will be required by name, for the following reasons:

  • cpu_load, flopy_any, mem_bw: Averages of these metrics are persisted in the SQLite DB and will be queried first from there.
  • mem_used: Logic is inverted for Footprint and has to be handled specifically -> The smaller the value, the better; This is defined in the metric thresholds.

@spacehamster87 spacehamster87 linked a pull request Sep 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend backend API related issues enhancement New feature or request frontend Svelte UI related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants