Skip to content
This repository has been archived by the owner on May 18, 2023. It is now read-only.

Trainer topic subscription idempotency. #90

Open
harrykeightley opened this issue Oct 18, 2022 · 0 comments
Open

Trainer topic subscription idempotency. #90

harrykeightley opened this issue Oct 18, 2022 · 0 comments
Labels
bug Something isn't working low priority

Comments

@harrykeightley
Copy link
Collaborator

harrykeightley commented Oct 18, 2022

The trainer subscription can fire the same training event multiple times, which would start different training run throughs on cloud run (wasting resources, overwriting models etc.).

This is not a priority to fix at this point, but something to think about.

Copying over a reply below from Nick.

Maybe I just put it as a flag on the firestore Model that training has begun?

If firebase has atomic transactions this might work, otherwise you're just going to have the same run condition in a different place. The ideal scenario is to have idempotent training jobs, where the end state isn't affected by multiple runs (either because it realised that a training job with the given inputs has already occurred and short-circuits, or it does the training again in a non-destructive way - both of these typically involve hash comparisons between inputs/outputs). This isn't easy to pull off, and probably isn't a priority at the moment, but something to think about.

Originally posted by @nicklambourne in #89 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working low priority
Projects
None yet
Development

No branches or pull requests

1 participant