-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect color interpretation when streaming via WebRTC #365
Comments
In our tests the following combo has always produced accurate results and my tests were run with: codec: VP8 From your FB tests it looks like this may be an issue in the original OBS and not the WebRTC implementation? Using these settings I see accurate color reproduction in OBSWebRTC-27.2.4, but not in V28. The screenshots below shows OBS window on the bottom, and Chrome 110.0.5481.177 on top. Running on MacOS 13.2.1 Below is a screen shot using OBS-WebRTC 27.2.4 (Release 1.3.2) And here is a screen shot with OBSWebRTC-28.1.1 |
I reproduced the problem with your settings. Key setting is color space: Rec 601 I am investigating the origin of this difference for color space 601. |
Thank you for your efforts on this. VP8 spec lists Rec601 as the correct color space, and so far that's the only way I've been able to get accurate color rendering is with the above settings. I never fully understood why h264 and other codecs don't render the colors correctly in this workflow. The problem is in OBS 28 Rec601 is no longer is accurate. At first I thought it was incorrectly using Rec701 color space, but my tests show a different color rendering for 601 and 709, both of which are incorrect. In these photos, top row is via chrome, middle row is OBS window, and bottom row is the source PNG I used. |
I confirm there is an issue in OBS 28 about color space 601.
Color management in OBS 28 has been modified a lot as compared to OBS 27. I have not yet identified how they changed management of color space for delivery of raw frames to encoder. |
Thank you for doing the raw frame comparison. Let me know if there is more I can do to help discover the root of the issue. |
Root of the issue has been identified as a difference in default format of raw frames to be delivered to libwebrtc for encoding.
|
Excellent! Thank you so much for your efforts in tracking this down and getting it corrected. |
Any word on when this fix will be implemented? Thanks |
Since upgrading to OBS 28 the video color is lifted when streaming with WebRtc.
If I switch the stream to Millicast RTMP then the colors are accurate. This was not an issue with OBS 27.2.4 via WebRTC.
In the photos below, the top color chart is Resolve which is the source. That's fed through a Black Magic UltraStudio Mini and received into OBS via a BLack Magic UltraStudio Mini. The bottom color chart is the received stream in a web browser.
See the photos below to highlight the color shift when using WebRTC.
Streaming via RTMP
Streaming via WebRTC
The text was updated successfully, but these errors were encountered: