Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved log files cannot be opened when "Auto Newline" is disabled. #352

Open
Ishmaeel opened this issue Mar 29, 2019 · 1 comment · May be fixed by #375
Open

Saved log files cannot be opened when "Auto Newline" is disabled. #352

Ishmaeel opened this issue Mar 29, 2019 · 1 comment · May be fixed by #375

Comments

@Ishmaeel
Copy link

Ishmaeel commented Mar 29, 2019 •
edited
Loading

Saved log files (*.dblog) cannot be opened when "Auto Newline" flag is disabled from Options menu. To reproduce:

  • Have some logs on screen. Save them to a .dblog file via "File > Save Log" command.
  • Make sure "Options > Auto Newline" menu item is not checked.
  • Try to load the saved file by double-clicking it in the file manager or by using "File > Open" command.

The application will treat the incoming data as a single-line message and try to cram all the contents into the first line. Sometimes nothing will happen, sometimes a single line containing all the messages will be shown. If the log file is very big, the application will probably hang.

Edit: Tested with the AppVeyor head version, which should be e2c804b or 395d3a9
@janwilmans
Copy link
Member

thanks for reporting... very strange indeed.. looking into it!

Ishmaeel added a commit to Ishmaeel/DebugViewPP that referenced this issue Jul 31, 2021
@Ishmaeel
Disregard "Auto Newline" user setting and always assume auto newline …
057a12e 
…in FileReader

This may not be the proper place to fix this but it works nicely at least as a temporary measure. The alternative is a potential DoS when trying to open large files as discussed in CobaltFusion#352.

Now FileReader always splits on newlines regardless of what the user selected for "Auto Newline" option from the menu. Fixes CobaltFusion#352.
@Ishmaeel Ishmaeel linked a pull request Jul 31, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Ishmaeel @janwilmans