Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample metadata to store information not already in updated.yaml #202

Open
JesusTorrado opened this issue Sep 22, 2021 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@JesusTorrado
Copy link
Contributor

Information that could be stored (in general, stuff about the chains themselves that is not already in the updated.yaml):

  • whether burn-in has been removed
  • whether the sample has been thinned
  • whether the sample has been cooled down
  • the sample temperature? (I guess not, since it's actually part of the sampler updated.yaml block?)

How to store that? A few alternatives:

  • Another block (analysis?) in the updated.yaml
  • Another file (could be GetDist's properties.ini)
@JesusTorrado JesusTorrado added the enhancement New feature or request label Sep 22, 2021
@cmbant cmbant mentioned this issue Feb 24, 2022
@cmbant
Copy link
Collaborator

cmbant commented Mar 13, 2023

Related to this is the annoying code duplication between getdist and cobaya, e.g. to get the ranges have to parse the parameter blocks. Potentially this could be part of metadata too.

@JesusTorrado
Copy link
Contributor Author

The code duplication is there in order not to need to have Cobaya installed to read chains with GetDist. I don't think it will be cured by adding more stuff to the metadata, since then we would be duplicating two things: (a) the metadata parser (we will also need it in Cobaya to load chains as Collections), and (b) the data themselves (not only ranges, but also labels, and possibly more).

From the user point of view, I would rather duplicate code (which as a user I don't see) than data (which as a user looks chaotic: which is the one I should trust / write my own parser for?).

@JesusTorrado
Copy link
Contributor Author

NB, as a reminder for myself: when we add the metadata, we should load the temperature from it, as opposed to from the samples as it is done right now.

@cmbant
Copy link
Collaborator

cmbant commented Mar 29, 2023

There probably isn't a very compelling reason for getdist not to just use cobaya when loading cobaya chains.

@cmbant
Copy link
Collaborator

cmbant commented Nov 10, 2023

Note grid scripts 326 currently use .properties.ini to store burn-removed info a la getdist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants