Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in BAO/RSD Likelihood with CLASS #44

Open
jcolinhill opened this issue Oct 8, 2019 · 7 comments
Open

Error in BAO/RSD Likelihood with CLASS #44

jcolinhill opened this issue Oct 8, 2019 · 7 comments

Comments

@jcolinhill
Copy link

Running the default SDSS DR12 BAO+RSD likelihood when using CLASS as the theory code produces the following error:

[9 : bao.sdss_dr12_consensus_final] Initialising.
[9 : classy] ERROR Requested product not known: {'fsigma8': {'z': array([0.38, 0.51, 0.61])}}

It looks like the interface to the CLASS computation of f*sigma8 is broken, which is probably an easy thing to fix.

Thanks for this great code!

@JesusTorrado
Copy link
Contributor

Hi @jcolinhill

fsigma8 is so far not implemented in CLASS. I did let their developers know about it a while ago, and I have been told it may come in the next version, 2.8, in a few days (with the caveat that they disagree about it's usefulness, given that it assumes a scale-independent growth factor).

@cmbant
Copy link
Collaborator

cmbant commented Oct 8, 2019

CAMB defines f sigma_8 so that it doesn't make that assumption following Eq 33 of Planck params 2015. (whether that's actually what is measured by surveys is another question..)

@jcolinhill
Copy link
Author

Hi @JesusTorrado @cmbant - thanks for the quick reply. Do you know if the updated CLASS version will be out very soon? If not, perhaps I'll try implementing the P15 prescription within CLASS...

@JesusTorrado
Copy link
Contributor

I have been told that it will be released in the next few weeks as CLASS 2.8.

If you want to make sure that fsigma8 is added in the new version, the best thing you can do is contacting CLASS' developers, and maybe offer them a pull request (but I would contact them first anyway, since they told me that they would probably include it themselves).

@lukashergt
Copy link
Contributor

Hi @jcolinhill and @JesusTorrado,

any update on this?

I believe classy now has a function called scale_independent_growth_factor_f in class_public/python/classy.pyx.
Could that be used in Cobaya's CLASS version of get_fsigma8 in cobaya/theories/classy/classy.py?

@JesusTorrado
Copy link
Contributor

Hi @lukashergt

I expect to be taking a look at this in the next few days. Once the German semester is over (~ Feb 15th) we can try to get Julien Lesgourgues involved too.

@JesusTorrado JesusTorrado mentioned this issue Mar 12, 2021
6 tasks
@JesusTorrado
Copy link
Contributor

scale_independent_growth_factor_f appears to be one piece of the thing, but we would still need the density-velocity correlation (see https://arxiv.org/pdf/1502.01589.pdf). Hopefully @lesgourg can add it? There is an issue open already at CLASS: lesgourg/class_public#393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants