Ja vr private descriptions #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…private descriptions for events that have them
Pull Request Test Coverage Report for Build 1145445894
💛 - Coveralls |
varunthakkar1
approved these changes
Aug 2, 2021
…ve-bus-frontend into JA-VR-private-descriptions
|
Does not show if not logged in: |
rymaju
approved these changes
Sep 30, 2021
| dispatch(upcomingEvents.loading()); | ||
| return publicApiClient | ||
| .getUpcomingEvents() | ||
| return eventsFetcher() |
There was a problem hiding this comment.
⛏️ Using a noun for a function name is generally bad, we would rather use a verb, i.e. fetchEvents()
| return (dispatch, getState, { publicApiClient }) => { | ||
| return (dispatch, getState, { publicApiClient, protectedApiClient }) => { | ||
| const eventsFetcher: () => Promise<EventInformation[]> = | ||
| getPrivilegeLevel(getState().authenticationState.tokens) === |
There was a problem hiding this comment.
⛏️ Not sure why we cant return this value directly and avoid defining a variable here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #163
Changes
Create/edit event forms should now include private descriptions
Frontend must display this field when registered users view the event on the single event view page