generated from Code-4-Community/frontend-scaffold
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ja vr private descriptions #176
Open
vrautela
wants to merge
12
commits into
master
Choose a base branch
from
JA-VR-private-descriptions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+68
−25
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b951a20
add private description field to create/edit event forms and display …
ja0911 521cd72
Changed private description condition
ja0911 6bb9345
Merge branch 'master' into JA-VR-private-descriptions
vrautela c39efc5
Merge branch 'master' into JA-VR-private-descriptions
varunthakkar1 71f7390
updated styling
varunthakkar1 2b2e39d
styling update
varunthakkar1 3a697c2
revert
varunthakkar1 e47bcbc
it works
rymaju 618b0db
linting
rymaju b1bcb39
Merge branch 'master' of https://github.com/Code-4-Community/lucys-lo…
rymaju 59471e4
explicitly cast to boolean
rymaju 3bfe348
use thunk extra args
rymaju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,18 @@ | ||
import { EventInformation, EventsThunkAction } from './types'; | ||
import { getPrivilegeLevel } from '../../../auth/ducks/selectors'; | ||
import { PrivilegeLevel } from '../../../auth/ducks/types'; | ||
import { upcomingEvents } from './actions'; | ||
import { EventInformation, EventsThunkAction } from './types'; | ||
|
||
export const getUpcomingEvents = (): EventsThunkAction<void> => { | ||
return (dispatch, getState, { publicApiClient }) => { | ||
return (dispatch, getState, { publicApiClient, protectedApiClient }) => { | ||
const eventsFetcher: () => Promise<EventInformation[]> = | ||
getPrivilegeLevel(getState().authenticationState.tokens) === | ||
PrivilegeLevel.NONE | ||
? publicApiClient.getUpcomingEvents | ||
: protectedApiClient.getProtectedEvents; | ||
|
||
dispatch(upcomingEvents.loading()); | ||
return publicApiClient | ||
.getUpcomingEvents() | ||
return eventsFetcher() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ⛏️ Using a noun for a function name is generally bad, we would rather use a verb, i.e. fetchEvents() |
||
.then((response: EventInformation[]) => { | ||
dispatch(upcomingEvents.loaded(response)); | ||
}) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛏️ Not sure why we cant return this value directly and avoid defining a variable here.