Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tested the manual Taking up of challenges with relevant snapshots #50

Closed
wants to merge 9 commits into from

Conversation

Sakalya100
Copy link

@Sakalya100 Sakalya100 commented Jun 16, 2021

Description

This PR is regarding feature request #11 in which test has been done successfully to check manual taking of various functionalities of challenges and relevant snapshots,gifs have been added

Related Issue

Fixes #11

Type of Contribution:

  • Bug fix
  • Coding
  • Design
  • Testing
  • Research
  • Enhancement
  • Documentation
  • Other :

Checklist:

  • I have read README.md and CONTRIBUTION.md
  • My Pull request is made against develop branch.
  • My code/design follows the style/guidelines of this project.
  • I have performed a self-review of my own code/design/documentation.
  • I have commented my code, particularly in hard-to-understand areas(or gave a proper description about the design).

Screenshots (if applicable):

@Sakalya100
Copy link
Author

@SHITIZ-AGGARWAL when will my PR be reviewed and merged?

Copy link
Member

@SHITIZ-AGGARWAL SHITIZ-AGGARWAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sakalya100 Refer this for how tests should be added. You have to make a new folder for snapshots. Also you have only added workflow. Refer this for seeing the formatting of tests and you have to include tests for every possible scenario.

@Sakalya100
Copy link
Author

@SHITIZ-AGGARWAL Okay I will make the necessary changes

@SHITIZ-AGGARWAL
Copy link
Member

@Sakalya100 Update

@Sakalya100
Copy link
Author

@SHITIZ-AGGARWAL will be done by tomorrow

@SHITIZ-AGGARWAL
Copy link
Member

@Sakalya100 any update on this

@SHITIZ-AGGARWAL
Copy link
Member

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Manual testing of taking up Challenges
2 participants