Replies: 3 comments 11 replies
-
|
Hey @Eshan05 Use tabs for respective components. So that it will be easier for people to easily navigate as well as to understand. As per your video reference above, For accordion COMPONENT tab will have a component code and the USAGE tab will have a usage code of that component right? |
Beta Was this translation helpful? Give feedback.
-
|
Yes precisely so user won't have to scroll up and down too much. |
Beta Was this translation helpful? Give feedback.
-
Yeah! Cool🤖✨ |
Beta Was this translation helpful? Give feedback.
-
|
Also @rakshixh, was I supposed to comment under the first Q&A discussion? I thought as your app grows and more discussion occurs it might get cluttered with threads in a single discussion so I made a separate discussion. Lmk so I'll post there instead |
Beta Was this translation helpful? Give feedback.
-
That's Okay, The Discussion is about helping the community. It goes fine by me.👾 |
Beta Was this translation helpful? Give feedback.
-
|
Also @Eshan05 I want to know one more thing, that is under the REACT sidebar menu, do you have a component page? Under REACT it is only for theory concepts. For example, after the Introduction page, you can have another page called "Hooks" where in this page you can list all react hooks with examples, their purpose how they works etc |
Beta Was this translation helpful? Give feedback.
-
|
No I have only done the introduction page as per issue. The components page was just me testing out links between pages, I haven't added anything to it but I figured that eventually there would an introduction to "Components and Props" so I was seeing if I can link to it in the Whats's next? thing alongside other such pages.. But seeing as there's a sidebar showing all pages I didn't make other pages and plan on deleting the components page too |
Beta Was this translation helpful? Give feedback.
-
For reference, in issue only introduction was mentioned so I have done only that. |
Beta Was this translation helpful? Give feedback.
-
|
Okay great, It's up to you since we are in the initial stage you can contribute as much as you like. But please make sure to conclude this issue in a single PR itself. And coming to "Components and Props" it can be included in the Introduction page itself. React => Introduction is about theory concepts not much about code snippets. |
Beta Was this translation helpful? Give feedback.
-
Yes of course As for the components and other pages under React.. I personally believe it would be better to have more specific pull requests and issues, to organize the repository and others can contribute too As for issue #4 I'll be making the PR soon |
Beta Was this translation helpful? Give feedback.
-
|
@Eshan05 Yeah, We are working on it! Thank you for your patience. |
Beta Was this translation helpful? Give feedback.
-
|
@Eshan05 When can we expect PR regarding the changes you have done? Or at least can we get the latest update on your changes here? |
Beta Was this translation helpful? Give feedback.
-
I think by tonight in few hours or max before tomorrow noon, I didn't have time to work on it today but only adding some more description for components and props definitions are remaining |
Beta Was this translation helpful? Give feedback.
-
|
Okay Sure. No worries! |
Beta Was this translation helpful? Give feedback.
-
@rakshixh, I have finished setting up mostly everything in terms of content just making changes to UI and way it looks on different viewports, I want to have your opinion on the components pages. Should I use tabs or should I have them separate (I mean the usage and component) [Issue #4]
jtZmftRLea.mp4
Beta Was this translation helpful? Give feedback.
All reactions