generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 240
Glasgow | 25-ITP-Sep | Abraham-Habte | Sprint 3 |Coursework/sprint-3-practice-tdd #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Abrsh100
wants to merge
9
commits into
CodeYourFuture:main
Choose a base branch
from
Abrsh100:coursework/sprint-3-practice-tdd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+94
−6
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
53f9188
new work space in vscode
Abrsh100 a825bf7
correctin and updating the exercise
Abrsh100 d873260
Answering each question with in the file by puting // to separate fro…
Abrsh100 872131a
solution for sprint 2
Abrsh100 2e1ae4a
correcting the code and testing using JS
Abrsh100 9859d0d
restoring sprint 2
Abrsh100 0c6b25c
changes are made based on feedback
Abrsh100 ed2e57d
communicating with the comment to resolve the issue
Abrsh100 2d04b9c
adding test to get-ordinal-number.test.js
Abrsh100 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,13 @@ | ||
| function repeat(word, n) { | ||
| if (typeof n !== 'number' || n < 0) { | ||
| return "Count must be a non-negative integer"; | ||
| } | ||
| throw new Error("Count must be a non-negative integer"); | ||
| } | ||
| if (n === 0) { | ||
| return " "; | ||
| return ""; | ||
| } | ||
| return word.repeat(n); | ||
| } | ||
|
|
||
| module.exports = repeat; | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make the test in this script more comprehensive? Ideally the test should include categories that can cover all valid numbers.