From 980395f4cf004872ea0ba0bc729e32f002f0a8e6 Mon Sep 17 00:00:00 2001 From: W0rma Date: Mon, 11 Nov 2024 08:12:57 +0100 Subject: [PATCH 1/4] Test against PHP 8.4 --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index cb6b04d..337e93c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -8,7 +8,7 @@ jobs: strategy: matrix: - php: [8.0, 8.1, 8.2, 8.3] + php: [8.0, 8.1, 8.2, 8.3, 8.4] steps: - name: Checkout code From d2d8b36572cddabace5fdd3124cdd368d39084a1 Mon Sep 17 00:00:00 2001 From: W0rma Date: Mon, 11 Nov 2024 08:13:12 +0100 Subject: [PATCH 2/4] Bump actions/checkout dependency --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 337e93c..1e8cbc7 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -12,7 +12,7 @@ jobs: steps: - name: Checkout code - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Setup PHP uses: shivammathur/setup-php@v2 From a9184bfd38be21b5f37f662c5db786ad46049dd4 Mon Sep 17 00:00:00 2001 From: W0rma Date: Mon, 11 Nov 2024 08:30:52 +0100 Subject: [PATCH 3/4] Drop support for PHP 8.0 --- .github/workflows/main.yml | 2 +- composer.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 1e8cbc7..d833ab6 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -8,7 +8,7 @@ jobs: strategy: matrix: - php: [8.0, 8.1, 8.2, 8.3, 8.4] + php: [8.1, 8.2, 8.3, 8.4] steps: - name: Checkout code diff --git a/composer.json b/composer.json index 56858d0..6e419f1 100644 --- a/composer.json +++ b/composer.json @@ -13,7 +13,7 @@ ], "homepage": "https://codeception.com/", "require": { - "php": "^8.0", + "php": "^8.1", "ext-mbstring": "*", "guzzlehttp/psr7": "^2.0", "phpunit/phpunit": "^9.5 | ^10.0 | ^11.0", From d1c818495b7ff8146195381f47ef3d464e198de9 Mon Sep 17 00:00:00 2001 From: W0rma Date: Mon, 11 Nov 2024 08:34:29 +0100 Subject: [PATCH 4/4] Remove superfluous check --- src/Util/Locator.php | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/Util/Locator.php b/src/Util/Locator.php index 1ca8dac..7e32e25 100644 --- a/src/Util/Locator.php +++ b/src/Util/Locator.php @@ -338,11 +338,9 @@ public static function humanReadableString(WebDriverBy|array|string $selector): $locator = $selector[$type]; return "{$type} '{$locator}'"; } - if (class_exists('\Facebook\WebDriver\WebDriverBy') && $selector instanceof WebDriverBy) { - $type = $selector->getMechanism(); - $locator = $selector->getValue(); - return "{$type} '{$locator}'"; - } - throw new InvalidArgumentException("Unrecognized selector"); + + $type = $selector->getMechanism(); + $locator = $selector->getValue(); + return "{$type} '{$locator}'"; } }