Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate either seeInSource() or seeInPageSource() #19

Open
ThomasLandauer opened this issue Sep 13, 2020 · 1 comment
Open

Deprecate either seeInSource() or seeInPageSource() #19

ThomasLandauer opened this issue Sep 13, 2020 · 1 comment

Comments

@ThomasLandauer
Copy link
Member

WebDriver::seeInSource() and WebDriver::seeInPageSource() both claim to do the same, but differ internally. Which one is the current/recommended? => Deprecate the other! (i.e. keep it as alias till v5.0, then remove it)
@ThomasLandauer
Copy link
Member Author

lib-innerbrowser has just seeInSource() - so this is probably the way to go.

@ThomasLandauer ThomasLandauer mentioned this issue Sep 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ThomasLandauer