Skip to content

Commit fc16dd3

Browse files
authored
Merge pull request #429 from Codeinwp/fix/onboarding-layout
fix: onboarding layout overflow and responsiveness
2 parents cd8b0e1 + 22a6781 commit fc16dd3

File tree

3 files changed

+22
-16
lines changed

3 files changed

+22
-16
lines changed

.github/workflows/e2e.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
run: npm run ci:e2e
3535
- name: Upload artifacts on failure
3636
if: failure()
37-
uses: actions/upload-artifact@v3
37+
uses: actions/upload-artifact@v4
3838
with:
3939
name: e2e-artifacts
4040
path: ./artifacts

onboarding/src/Components/Steps/SiteList.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,11 @@ const SiteList = ( { showToast, setShowToast, setFetching } ) => {
4444
}, [] );
4545

4646
return (
47-
<div className="ob-container wide">
48-
<div className="ob-title-wrap">
49-
<h1>
50-
{ __( 'Choose a design', 'templates-patterns-collection' ) }
47+
<div className="ob-container">
48+
<div className="ob-container-inner">
49+
<div className="ob-title-wrap">
50+
<h1>
51+
{ __( 'Choose a design', 'templates-patterns-collection' ) }
5152
</h1>
5253
<EditorSelector />
5354
</div>
@@ -61,6 +62,7 @@ const SiteList = ( { showToast, setShowToast, setFetching } ) => {
6162
message={ toastMessage }
6263
/>
6364
) }
65+
</div>
6466
</div>
6567
);
6668
};

onboarding/src/scss/_general.scss

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,14 @@ iframe {
6464
height: 100%;
6565
}
6666

67+
.ob-container-inner {
68+
max-width: 1400px;
69+
margin: 0 auto;
70+
width: 100%;
71+
padding: 25px;
72+
box-sizing: border-box;
73+
}
74+
6775
.ob-container {
6876
flex-direction: column;
6977
display: flex;
@@ -101,17 +109,7 @@ iframe {
101109
display: grid;
102110
grid-row-gap: 24px;
103111
grid-column-gap: 24px;
104-
grid-template-columns: repeat(auto-fit, minmax(200px, 1fr));
105-
106-
justify-content: space-between;
107-
108-
@media (min-width: 650px ) {
109-
grid-template-columns: 1fr 1fr 1fr;
110-
}
111-
112-
@media (min-width: 1400px) {
113-
min-width: 1400px;
114-
}
112+
grid-template-columns: 1fr;
115113
}
116114

117115
.ob-title-wrap {
@@ -213,9 +211,15 @@ input.components-text-control__input[type="email"],
213211
}
214212

215213
@mixin ob-general--laptop() {
214+
.ob-sites.is-grid {
215+
grid-template-columns: 1fr 1fr 1fr;
216+
}
216217
}
217218

218219
@mixin ob-general--tablet() {
220+
.ob-sites.is-grid {
221+
grid-template-columns: 1fr 1fr;
222+
}
219223
}
220224

221225
.components-modal__content:has( .ob-modal-confirm-title ) .components-button.is-tertiary {

0 commit comments

Comments
 (0)