Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

fix(website): change buttons sizes on mobile (#337) #344

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(website): change buttons sizes on mobile (#337) #344

wants to merge 2 commits into from

Conversation

mrpodkalicki
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Sep 12, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

coderscamp-website – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-website/GrSS9mTZDNR4Zzz1iHDpPrSX5Bnd
✅ Preview: https://coderscamp-website-git-issue-337-changebutton-266ed9-coderscamp.vercel.app

coderscamp-storybook – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-storybook/HimHoQDXCYHvAZaUAqDUfB8ih1wP
✅ Preview: https://coderscamp-storybook-git-issue-337-changebutt-1b3e51-coderscamp.vercel.app

coderscamp-docs – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-docs/Do54J6a1sfCwkAZVk28Qw5WCpfCC
✅ Preview: https://coderscamp-docs-git-issue-337-changebuttonssi-86d16e-coderscamp.vercel.app

@KonradSzwarc KonradSzwarc temporarily deployed to coderscamp-issue-337-ch-uj52m8 September 12, 2021 22:20 Inactive
@mrpodkalicki mrpodkalicki linked an issue Sep 12, 2021 that may be closed by this pull request
Change buttons sizes on mobile #337
Open
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2021 •
edited
Loading

Codecov Report

Merging #344 (e64e9c3) into main (e1801d7) will decrease coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
- Coverage   88.43%   87.92%   -0.51%     
==========================================
  Files         150      150              
  Lines        1773     1806      +33     
  Branches      232      236       +4     
==========================================
+ Hits         1568     1588      +20     
- Misses        204      217      +13     
  Partials        1        1
Flag Coverage Δ
api 85.67% <ø> (-0.57%) ⬇️
ui 99.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...th/automation/user-registration-started.handler.ts 37.50% <0.00%> (-50.00%) ⬇️
...on/application/user-registration-emails.service.ts 75.00% <0.00%> (-25.00%) ⬇️
...ation/application/register-user.command-handler.ts 96.00% <0.00%> (-4.00%) ⬇️
packages/api/src/shared/env.ts 100.00% <0.00%> (ø)
...i/src/crud/user-profile/user-profile.repository.ts
.../api/src/crud/user-profile/user-profile.service.ts
...i/src/crud/user-profile/user-profile.controller.ts
...s/api/src/crud/user-profile/user-profile.module.ts
...-profile-when-registration-completed.automation.ts
...dule/read/user-profile/user-profile.read-module.ts 84.21% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1801d7...e64e9c3. Read the comment docs.

@KrystianKjjk KrystianKjjk added the 🦄 for design review PR should be reviewed by someone from the design team label Sep 13, 2021
wierzbka10
wierzbka10 suggested changes Sep 13, 2021
View reviewed changes
Copy link

@wierzbka10 wierzbka10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buttons on the picture below should be the width of the box

butony mobilka długosc

@mrpodkalicki mrpodkalicki force-pushed the issue-337-Change_buttons_sizes_on_mobile branch from 435edf2 to ccf5821 Compare September 30, 2021 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lagdush lagdush lagdush approved these changes

@KonradSzwarc KonradSzwarc Awaiting requested review from KonradSzwarc

@KrystianKjjk KrystianKjjk Awaiting requested review from KrystianKjjk

@talcia talcia Awaiting requested review from talcia

@MateuszNaKodach MateuszNaKodach Awaiting requested review from MateuszNaKodach

@Veryyapeee Veryyapeee Awaiting requested review from Veryyapeee

@wierzbka10 wierzbka10 Awaiting requested review from wierzbka10

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🦄 for design review PR should be reviewed by someone from the design team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change buttons sizes on mobile
6 participants
@mrpodkalicki @codecov-commenter @lagdush @wierzbka10 @KonradSzwarc @KrystianKjjk