Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python 3.13 #28

Open
mattmart3 opened this issue Feb 20, 2025 · 0 comments
Open

Support python 3.13 #28

mattmart3 opened this issue Feb 20, 2025 · 0 comments

Comments

@mattmart3
Copy link

mattmart3 commented Feb 20, 2025

Using doorstop from pre-commit hooks with pre-commit v4.0.1 I encountered the following issue:

check for doorstop errors................................................Failed
- hook id: check-doorstop-errors
- duration: 0.24s
- exit code: 1

Traceback (most recent call last):
  File "/home/user/.cache/pre-commit/repobelzyq3i/py_env-python3.13/bin/doorstop", line 5, in <module>
    from doorstop.cli.main import main
  File "/home/user/.cache/pre-commit/repobelzyq3i/py_env-python3.13/lib/python3.13/site-packages/doorstop/__init__.py", line 8, in <module>
    from doorstop.core import (
    ...<11 lines>...
    )
  File "/home/user/.cache/pre-commit/repobelzyq3i/py_env-python3.13/lib/python3.13/site-packages/doorstop/core/publisher.py", line 10, in <module>
    from doorstop.core.publishers.html import HtmlPublisher
  File "/home/user/.cache/pre-commit/repobelzyq3i/py_env-python3.13/lib/python3.13/site-packages/doorstop/core/publishers/html.py", line 9, in <module>
    import bottle
  File "/home/user/.cache/pre-commit/repobelzyq3i/py_env-python3.13/bin/bottle.py", line 38, in <module>
    import base64, cgi, email.utils, functools, hmac, itertools, mimetypes,\
            os, re, subprocess, sys, tempfile, threading, time, warnings, hashlib
ModuleNotFoundError: No module named 'cgi'

It looks like that the cgi module is no longer supported with python3.13, which is the version used by the recent pre-commit.

I haven't checked it in details but it looks like upstream doorstop already supports python3.13, thus pulling from upstream may fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant