Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile.cc-ubuntu-skyhook arguments #284

Closed
fengpinghu opened this issue Apr 22, 2022 · 1 comment
Closed

Dockerfile.cc-ubuntu-skyhook arguments #284

fengpinghu opened this issue Apr 22, 2022 · 1 comment

Comments

@fengpinghu
Copy link

It appears setting some of the environment variables in this docker file is not working. My suspect is that it can not overwrite a environment from base image(I have not yet find a reference to confirm this). So we should remove these because they are misleading and have no effect. We could pass the environment variable via the helm chart instead of passing them at image build time.
Examples:
ARG WORKER_IMAGE="${HUB}/${PROJECT}/cc-analysis-ubuntu"
ENV WORKER_IMAGE=$WORKER_IMAGE

@oshadura
Copy link
Member

We deleted skyhook images from the repository, so the issue is not valid anymore.

Separately, I am adding the issue to move the config files in the helm charts: #407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants