Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing information about how to install coffea for notebook example #1089

Open
kratsg opened this issue May 2, 2024 · 3 comments
Open

Missing information about how to install coffea for notebook example #1089

kratsg opened this issue May 2, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@kratsg
Copy link
Contributor

kratsg commented May 2, 2024

Currently, if you just run pip install coffea and then run a notebook example like: https://coffeateam.github.io/coffea/notebooks/processor.html -- it will fail due to missing imports, likely from a feature/contrib that needs to be put as part of the install.

I would suggest putting an example install command at the top of each notebook to indicate the requirements for running that nb?

@kratsg kratsg added the bug Something isn't working label May 2, 2024
@ikrommyd
Copy link
Contributor

ikrommyd commented May 6, 2024

Is the only issue dask.distributed missing? If that's the case pip install coffea[dask] is what is required. Perhaps advertising that is the solution.

@kratsg
Copy link
Contributor Author

kratsg commented May 6, 2024

Is the only issue dask.distributed missing? If that's the case pip install coffea[dask] is what is required. Perhaps advertising that is the solution.

Yeah, I think this is going to apply to all notebooks, as it's not necessarily clear otherwise.

@ikrommyd
Copy link
Contributor

ikrommyd commented May 7, 2024

Should the dask optional dependencies become part of the required dependencies since coffea is now technically dask-only @lgray?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants