Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paths drop parameters in unstrip_protocol #64

Closed
nsmith- opened this issue Aug 6, 2024 · 0 comments · Fixed by #65
Closed

Paths drop parameters in unstrip_protocol #64

nsmith- opened this issue Aug 6, 2024 · 0 comments · Fixed by #65

Comments

@nsmith-
Copy link
Member

nsmith- commented Aug 6, 2024

Symptom:

import fsspec

url = "root://eospublic.cern.ch//eos/root-eos/benchmark/Run2012B_SingleMu.root?blah=blah"
fs, path = fsspec.core.url_to_fs(url)
print(fs, path)

returns

<fsspec_xrootd.xrootd.XRootDFileSystem object at 0x10ad0d040> /eos/root-eos/benchmark/Run2012B_SingleMu.root

the second argument should be /eos/root-eos/benchmark/Run2012B_SingleMu.root?blah=blah, but the parameters are dropped.

The issue is that we are using XRootD.client.URL.path when we should be using path_with_params in

fsspec-xrootd/src/fsspec_xrootd/xrootd.py

Line 305 in 784540c

return client.URL(path).path.rstrip("/") or cls.root_marker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve parameters in paths CoffeaTeam/fsspec-xrootd
1 participant
@nsmith-