Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn on coffea tests when CoffeaTeam/coffea#882 is merged #1

Open
lgray opened this issue Dec 5, 2023 · 1 comment
Open

turn on coffea tests when CoffeaTeam/coffea#882 is merged #1

lgray opened this issue Dec 5, 2023 · 1 comment

Comments

@lgray
Copy link

lgray commented Dec 5, 2023

Right now coffea tests take a rather long amount of time, but the mentioned PR, CoffeaTeam/coffea#882, vastly reduces testing so that we can always run all tests.

@lgray lgray changed the title turn on coffea tests when https://github.com/CoffeaTeam/coffea/pull/882 is merged turn on coffea tests when CoffeaTeam/coffea#882 is merged Dec 5, 2023
@jpivarski
Copy link
Collaborator

For some reason, I couldn't use micromamba to install ROOT, so I used the standard miniconda action, and there's no caching for compiling awkward-cpp. I took that out to get it working and not get confused by hold-overs from previous runs.

If you want to do some big 20 or 30 minute test of a distributed job in Coffea, then this is appropriate. It can run once a day (using up 6 test runners), and that would be fine. When integration fails, we shouldn't try to debug it in the GitHub Action, but in a local checkout. (I'm expecting this to catch incompatibilities introduced in the latest version of one of these four packages, which shouldn't appear in Windows-only, which is the only one I don't know how to debug outside of GitHub Actions.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants