Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to /etc/condor/condor_config #11

Open
mapsacosta opened this issue Apr 14, 2022 · 4 comments
Open

Fallback to /etc/condor/condor_config #11

mapsacosta opened this issue Apr 14, 2022 · 4 comments
Labels
question Further information is requested

Comments

@mapsacosta
Copy link

The Schedd class is only capable of using a condor_config file present in the same folder. In order to make this code friendlier with people running their own variations of condor, the line:

os.environ["CONDOR_CONFIG"] = os.path.join(os.path.dirname(__file__), "condor_config")

Should fallback to the default directory /etc/condor/condor_config and then fail.

The location of the condor_config could also be a configurable parameter

@nsmith-
Copy link
Member

nsmith- commented Apr 20, 2022

I think then we would want a separate docker image on top of docker-coffea-dask that adds this file, for use at LPC, right?

@mapsacosta
Copy link
Author

Yep, in our case we just pull the file (and other condor configs) from Git with an initContainer.
I could also see this as either a configurable parameter or an environment variable, especially if we're trying to extend to other places (such as lxplus). I am working on a quick MR to implement falling back to the default condor installation file and we can re-iterate if needed.

@nsmith-
Copy link
Member

nsmith- commented Apr 20, 2022

Sounds good. Then, what to do about the schedd picking algorithm? It currently is somewhat LPC-specific, idk what it would do at other sites.

@nsmith-
Copy link
Member

nsmith- commented Oct 26, 2023

As of #21 we now just always load the path

os.environ["CONDOR_CONFIG"] = os.path.join("/srv/.condor_config")

Does that work for you, or should we do a if os.path.exists and then fallback to /etc/condor/condor_config? (actually if we just don't set the env variable, that is the default right?

@nsmith- nsmith- added the question Further information is requested label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants