Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement in error response /v1/crowdactions/slug/{slug} and /v1/crowdactions/{id} #114

Open
dromerolovo opened this issue Jan 27, 2023 · 0 comments
Assignees

Comments

@dromerolovo
Copy link
Member

dromerolovo commented Jan 27, 2023

Regarding /v1/crowdactions/slug/{slug} endpoint:

When requesting a crowdaction by a slug that doesn't exist, there is a mismatch in the response between the Status of the response: 500 and the statusCode of the response body "statusCode": 400 could be confusing for the client. Would be better if both are 404 Not Found.

Regarding /v1/crowdactions/{id} endpoint:

When requesting a crowdaction by an id that doesn't exist, the Status of the response is 500. Would be more convenient if the response is 404 Not Found.

@fredabisai fredabisai self-assigned this May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants