Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond to thread regarding card/banner sizes #7

Open
tomsiebring opened this issue Apr 1, 2023 · 1 comment
Open

Respond to thread regarding card/banner sizes #7

tomsiebring opened this issue Apr 1, 2023 · 1 comment
Assignees

Comments

@tomsiebring
Copy link
Contributor

tomsiebring commented Apr 1, 2023

Respond to this thread: is there a specific reason for these ratios for the design? Wouldn't e.g. 300x400 make more sense?

@tomsiebring tomsiebring changed the title Respond to [this thread](https://collaction-team.slack.com/archives/C0428K70A1F/p1678787194894679?thread_ts=1678735089.955049&cid=C0428K70A1F) regarding card/banner sizes Respond to thread regarding card/banner sizes Apr 1, 2023
@Xazin
Copy link
Member

Xazin commented Apr 1, 2023

Simply because that's the pixels we use as boundaries in the app, it's designed with X height (310px) and the example uses 410px width (but it's dynamic), thus that's how we've done it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants