Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Double rendering #10980

Open
mmeeks opened this issue Jan 21, 2025 · 3 comments
Open

perf: Double rendering #10980

mmeeks opened this issue Jan 21, 2025 · 3 comments
Assignees
@eszkadev
Labels
24.04 enhancement New feature or request performance Improving COOL performance

Comments

@mmeeks
Copy link
Contributor

mmeeks commented Jan 21, 2025

Open a spreadsheet, hit page-down a few times - notice some tiles have been rendered twice.

We should save that double rendering. I believe this is because we send a tilecombine that is interpreted as being a request to force rendering of a tile - and the JS client shoudl not have that 'power' - it should be sent a cached version.

Meanwhile DocumentBroker needs a way to force a new key-frame, and I tihnk the JS does this by accident, and sometimes these race unhelpfully.

So the 'oldwid=' thing needs adapting / filtering from the JS side to avoid this in the Kit/ code =)

Thanks !
@mmeeks mmeeks added 24.04 enhancement New feature or request performance Improving COOL performance unconfirmed labels Jan 21, 2025
@mmeeks
Copy link
Contributor Author

mmeeks commented Jan 21, 2025

You can see the count of tile rendering in the grid overlay over the tiles with details there.

eszkadev added a commit that referenced this issue Feb 11, 2025
@eszkadev
tiles: do not duplicate rendering if tilecombine requested
8f0ce4a 
related to #10980

open calc and use page down to enter some initially not visible area
notice in debug tools that tiles are rendered twice

If any tile rendering is already pending - let's don't request
it again. Use shared function for that check which was used only
in one place but forgotten in hadnling the incoming tilecombine message.

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: Icc1bf97826ec8b1cb1185b6f30dc2daf6d0355ea
@eszkadev eszkadev mentioned this issue Feb 11, 2025
Merged
@eszkadev
Copy link
Contributor

I have initial PR for that: #11134
seems to not hit 3 or more tiles on page down as before in manual testing :)

@mmeeks
Copy link
Contributor Author

mmeeks commented Feb 11, 2025

Looks good - approved; but would be good to have Caolan's comment closed in there =) thanks !

eszkadev added a commit that referenced this issue Feb 12, 2025
@eszkadev
tiles: do not duplicate rendering if tilecombine requested
b6fae29 
related to #10980

open calc and use page down to enter some initially not visible area
notice in debug tools that tiles are rendered twice

If any tile rendering is already pending - let's don't request
it again. Use shared function for that check which was used only
in one place but forgotten in hadnling the incoming tilecombine message.

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: Icc1bf97826ec8b1cb1185b6f30dc2daf6d0355ea
eszkadev added a commit that referenced this issue Feb 12, 2025
@eszkadev
tiles: do not duplicate rendering if tilecombine requested
7428e9a 
related to #10980

open calc and use page down to enter some initially not visible area
notice in debug tools that tiles are rendered twice

If any tile rendering is already pending - let's don't request
it again. Use shared function for that check which was used only
in one place but forgotten in hadnling the incoming tilecombine message.

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: Icc1bf97826ec8b1cb1185b6f30dc2daf6d0355ea
eszkadev added a commit that referenced this issue Feb 12, 2025
@eszkadev
tiles: do not duplicate rendering if tilecombine requested
4c85039 
related to #10980

open calc and use page down to enter some initially not visible area
notice in debug tools that tiles are rendered twice

If any tile rendering is already pending - let's don't request
it again. Use shared function for that check which was used only
in one place but forgotten in hadnling the incoming tilecombine message.

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: Icc1bf97826ec8b1cb1185b6f30dc2daf6d0355ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eszkadev eszkadev

Labels
24.04 enhancement New feature or request performance Improving COOL performance
Projects
Collabora Online
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mmeeks @eszkadev @thebearon